Should I give my child separate money (to spend) and separate money to save (to inculcate the saving habit)?

Keep the allowance constant. It should be enough to cover your child’s expenses and a bit more to inculcate savings. This way they will learn that there is a fixed amount of money and they have to save from that.